Sanitize S2I Builder tests #6810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
[test] again |
|
LGTM |
|
@bparees PTAL |
|
lgtm, need squashing. |
And: - Kill code duplication in pkg/build/builder tests - Repair godocs - Remove dead code
rhcarvalho
force-pushed
the
sanitize-s2i-builder-tests
branch
from
be80bf8
to
564a7e5
Compare
|
@bparees done |
|
Evaluated for origin test up to 564a7e5 |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4749/) (Image: devenv-rhel7_3250) |
|
Evaluated for origin merge up to 564a7e5 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/452/) |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 27, 2016
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across duplication and test names that say one thing and test another while working on #6715.
If all changes proposed here are fine I can squash into a single commit.