Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run post build hook with /bin/sh -ic #7379

Merged
merged 1 commit into from
Feb 23, 2016

Commits on Feb 22, 2016

  1. Run post build hook with /bin/sh -ic

    We need either `/bin/bash -c` or `/bin/sh -ic` to make our supported
    SCL-powered images to work properly. That's due to a hack to auto-enable
    SCLs:
    https://github.com/openshift/sti-base/blob/8d95148/Dockerfile#L23-L29
    
    In CentOS and RHEL images, `/bin/sh` is a symlink to `/bin/bash`. In
    that case, the ENV environment variable is only evaluated when the shell
    is started in interactive mode, which happens when there's and attached
    tty (not the case for post build hook) or when the `-i` argument is
    passed explicitly.
    
    Making the shell interactive with `-i` is ugly, but is the only solution
    we know so far without requiring Bash.
    rhcarvalho committed Feb 22, 2016
    1 Configuration menu
    Copy the full SHA
    46e7e91 View commit details
    Browse the repository at this point in the history