Replace /bin/bash in oc rsh with /bin/sh -i

[mfojtik]

Fixes: #7514

[mfojtik]

@bparees PTAL

[mfojtik]

@bparees @smarterclayton fyi, the web console already use interactive (-i) because the SCL is enabled there but the prompt says "sh" ;-)

[mfojtik]

and surprisingly, the oc rsh foo enters the interactive shell even if the -i is not specified.

[smarterclayton]

I think it's because it has a tty

[mfojtik]

@smarterclayton which leaves us broken with SCL only when you invoke oc exec foo /bin/sh -c "ruby" and we can 'workaround' this by having tty: true by default there (it is false now).

[smarterclayton]

We can't make exec default to tty, that isn't backwards compatible. Is the path variable not defined in the container (assuming that has an effect)?

[mfojtik]

@smarterclayton I assume SCL is not just about the PATH, there is more magic done depending on collection :-(

[bparees]

lgtm. [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5063/) (Image: devenv-rhel7_3506)

[openshift-bot]

Evaluated for origin merge up to 3b12c0e

[smarterclayton]

Release note this and also send something to users list