Prevent POODLE vulnerability in HAProxy router #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-bot
added
the
needs-rebase
|
Rebased onto master. |
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
openshift-bot
added
needs-rebase
openshift-bot
added
needs-rebase
|
@knobunc Needs review. |
|
After rebasing, only POODLE needed to be handled. |
elyscape
changed the title
openshift-bot
removed
the
needs-rebase
HAProxy 1.5.14 is now available and used by the router image.
elyscape
force-pushed
the
update-images
branch
from
d51939b
to
be9c4de
Compare
|
Rebased onto master again. It probably wasn't necessary but I did it anyway! |
|
@knobunc bump |
|
@pweil- @smarterclayton -- Do we care about any web browsers that can't speak SSLv3? |
I believe the major browsers disabled it at the end of 2014. IMO if we aren't going to break a bunch of folks it seems safest to disable it in haproxy too, folks still have the option to turn it back on. |
|
I agree - we should be regularly updating to have a secure router ootb.
However, any change to the support ciphers / suites should be a release
note. Also, we should update the "secure settings comment" alongside it.
…On Tue, Feb 7, 2017 at 1:44 PM, Paul Weil ***@***.***> wrote:
Do we care about any web browsers that can't speak SSLv3
I believe the major browsers disabled it at the end of 2014. IMO if we
aren't going to break a bunch of folks it seems safest to disable it in
haproxy too, folks still have the option to turn it back on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7638 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p0SSpAtr_Oftwv0D1ZHVHQoC-KuDks5raLuIgaJpZM4HjJ2l>
.
|
|
@openshift/networking FYI [merge] |
|
@smarterclayton how do we get this into the release notes? |
|
Evaluated for origin merge up to be9c4de |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/931/) (Base Commit: 596d795) (Image: devenv-rhel7_6331) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with a few TODO items in some of the images.