Add unique suffix to build post-hook containers #8316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it closer to pkg/kubelet/dockertools.BuildDockerName, as documented and as originally intended. We had removed the suffix during code review, and now agreed that it should be there to avoid bugging users with errors because of a container name clash.
|
@bparees PTAL. I'm marking this as fixing the issue because the other two actionable items in the issue all already have their own issues or PRs for us to track. [test] |
|
Evaluated for origin test up to 43ad146 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2623/) |
|
Test failures in Jenkins say: Seems unrelated to this change. There was a reported flake for this test a while ago #7355 |
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5493/) (Image: devenv-rhel7_3880) |
|
Evaluated for origin merge up to 43ad146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it closer to
pkg/kubelet/dockertools.BuildDockerName, as documented and as originally intended (original discussion in #6715 (comment)).We had removed the suffix during code review, and now agreed that it should be there to avoid bugging users with errors because of a container name clash.
Fixes #8266.