Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denylist: Drop coreos.ignition.journald-log from denylist #1196

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

gursewak1997
Copy link
Contributor

@gursewak1997 gursewak1997 commented Mar 14, 2023

Enabling ignition.journald-log as the test now runs and passes for RHCOS.

@openshift-ci openshift-ci bot requested review from aaradhak and mike-nguyen March 14, 2023 15:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@dustymabe
Copy link
Member

Closes: coreos/coreos-assembler#1173

Let's remove this from the commit and description of this PR. Unfortunately that issue doesn't exactly describe the underlying problem here and should be dealt with separately.

@gursewak1997 gursewak1997 force-pushed the updateDenylist branch 3 times, most recently from 8fd3e42 to 483a5c3 Compare March 14, 2023 20:53
The test runs and passes now that RHCOS is on Ignition spec3x
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe dustymabe merged commit 2b2d749 into openshift:master Mar 14, 2023
@gursewak1997 gursewak1997 deleted the updateDenylist branch March 14, 2023 20:53
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, gursewak1997

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,gursewak1997]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@gursewak1997: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-90-build-test-qemu 5d8faa1 link true /test rhcos-90-build-test-qemu
ci/prow/rhcos-86-build-test-metal 5d8faa1 link true /test rhcos-86-build-test-metal
ci/prow/rhcos-86-build-test-qemu 5d8faa1 link true /test rhcos-86-build-test-qemu
ci/prow/rhcos-90-build-test-metal 5d8faa1 link true /test rhcos-90-build-test-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants