-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.13 9.2 #1210
4.13 9.2 #1210
Conversation
Unfortuantely, we're not yet ready to move to the new containers/toolbox workflow. We'll attempt that for a future release. See: https://issues.redhat.com/browse/OCPBUGS-8009 Partially reverts: openshift@65776fa (cherry picked from commit 3eb4abb)
(cherry picked from commit aa7f640)
(cherry picked from commit 54daebb)
(cherry picked from commit ab22dee)
(cherry picked from commit be10693)
(cherry picked from commit 27cd97c)
Since we don't have a legacy toolbox build in OCP channels yet. (cherry picked from commit cdeb252)
With this things build for me. (cherry picked from commit fa8eef4)
(cherry picked from commit ee85017)
@cgwalters: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(cherry picked from commit a5eb84a)
OK lifting draft, I've tested this in a local build so far as
|
/override ci/prow/rhcos-92-build-test-metal |
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Argh. FTR I accidentally force-pushed this branch to Timothée's original branch for the 4.14 PR over at #1204 |
/test ci/prow/scos-9-build-test-metal |
@cgwalters: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/rhcos-92-build-test-metal |
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
I was sanity checking this by doing
Which generally looks sane to me. |
I don't see anything scary in the PR. A lot of removing of the old manifest and consolidating into a 9/9.2 manifests and a few scripts. Changes look sane to me, but tests gonna be the ultimate judge. |
@cgwalters: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OK, I logged into the pods and verified that scos9 is building, the kola tests are running. I'm not totally sure about waiting the whole cycle for all of those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jmarrero, ravanelli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ah, now looks like we're hitting tide ratelimiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in here is cherry-picks ✔️ except for the last commit:
c9s: Use 9.2 OCP
Would be nice to have more context in that commit message. Otherwise LGTM.
/lgtm
Thanks for double checking! Agree on the last commit, I basically ran out of steam in understanding the repo setups here (particularly |
This is a manual backport of #1204
(Because that one got entangled with the 4.14 branching)
manifest/9.2: Ensure package come from RHEL by default
Make sure that we use RHEL (and not RHAOS) packages by default.
(cherry picked from commit 49f9824)
overlay: Remove unused 25rhcos-azure-udev-rules
Not needed (and not actually used right now) in RHEL 8.6+ anymore.
(cherry picked from commit 5d5d0c5)
denylist: Skip ext.config.shared.ignition.resource.remote
See #1190
(cherry picked from commit d47155a)
s390x/kola-denylist: Re-enable working tests
fips.enable* is working on newest s390x. Remove the test from denylist.
For more details see #546
coreos.ignition.mount.* is fixed with gdisk-1.0.3-9.el8. Remove the test from
denylist.
ext.config.shared.ignition.stable-boot is fixed in RHEL 9. Only disable for
RHEL 8 builds.
Signed-off-by: Jan Schintag jan.schintag@de.ibm.com
(cherry picked from commit 36729d1)
gitmodules: track rhcos-4.13 branch
Start tracing the rhcos-4.13 branch of fedora-coreos-config as a
part of branching for 4.13.
bump f-c-c submodule to track rhcos-4.13 branch
denylist: All ignition.resource.remote
Maintaining this test just requires way too much intricate
stuff to be chained together.
Merge pull request #1198 from travier/4.13-backports
[4.13] Backports from 4.14
Revert "manifest/9.2: Ensure package come from RHEL by default"
We already have to use coreos-installer from the RHAOS repo and it's
likely that we will have to do it again in the future for 4.14.
Remove this to avoid having to make a PR for each package.
This reverts commit 49f9824.
(cherry picked from commit e346f8a)
manifest/9.2: Keep legacy coreos/toolbox
Unfortuantely, we're not yet ready to move to the new containers/toolbox
workflow. We'll attempt that for a future release.
See: https://issues.redhat.com/browse/OCPBUGS-8009
Partially reverts: 65776fa
(cherry picked from commit 3eb4abb)
manifests: Merge common-el9.yaml into common.yaml
(cherry picked from commit aa7f640)
manifests/9.2: Use RHEL 9.2 repos
(cherry picked from commit 54daebb)
manifest/c9s: Disable all repos by default
(cherry picked from commit ab22dee)
manifests: Remove RHEL 8 manifests
(cherry picked from commit be10693)
manifests: Remove RHEL 9.0 manifests
(cherry picked from commit 27cd97c)
manifest: Back to rhel toolbox
Since we don't have a legacy toolbox build in OCP channels yet.
(cherry picked from commit cdeb252)
rhel-9.2: Fix two more references to 9.0
With this things build for me.
(cherry picked from commit fa8eef4)
More 90 -> 92 adjustments
(cherry picked from commit ee85017)