Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usermod workaround for openvswitch hugetlbfs group #1318

Conversation

dustymabe
Copy link
Member

The RPM is now using systemd-sysusers fragments [1] and the RPM scriptlets no longer successfully add the hugetlbfs group to the openvswitch user [2]. Let's add a workaround for now while we investigate.

[1] #1274 (comment)
[2] #1274 (comment)

@openshift-ci openshift-ci bot requested review from c4rt0 and HuijingHei June 18, 2023 20:30
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2023
@HuijingHei
Copy link
Contributor

ext.config.files.openvswitch-hugetlbfs-groups is failed on c9s, maybe it also needs the workaround?

    --- FAIL: non-exclusive-test-bucket-0/ext.config.files.openvswitch-hugetlbfs-groups (2.78s)
            cluster.go:162: Error: Unit kola-runext-9.service exited with code 1

The RPM is now using systemd-sysusers fragments [1] and the RPM
scriptlets no longer successfully add the `hugetlbfs` group to the
`openvswitch` user [2]. Let's add a workaround for now while we investigate.

[1] openshift#1274 (comment)
[2] openshift#1274 (comment)
@dustymabe dustymabe force-pushed the dusty-fix-openvswitch-groups-2 branch from 5e44ef8 to 98e8d99 Compare June 19, 2023 14:39
@dustymabe
Copy link
Member Author

ext.config.files.openvswitch-hugetlbfs-groups is failed on c9s, maybe it also needs the workaround?

ahh. yeah I didn't add it to a shared manifest. Just pushed up a commit moving it to a shared manifest so hopefully it works now.

@dustymabe
Copy link
Member Author

/retest

Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LorbusChris
Copy link
Member

It looks like https://src.fedoraproject.org/rpms/systemd/blob/rawhide/f/sysusers.generate-pre.sh and https://pkgs.devel.redhat.com/cgit/rpms/systemd/tree/sysusers.generate-pre.sh?h=rhel-9.2.0 have diverged, and the latter is missing multiple updates to the script.

Specifically, this change that is missing in RHEL looks like the culprit to me: https://src.fedoraproject.org/rpms/systemd/c/f27d461663bec17ad64422682f260f0020ccc7f7?branch=rawhide

@HuijingHei
Copy link
Contributor

/retest-required

1 similar comment
@HuijingHei
Copy link
Contributor

/retest-required

@dustymabe
Copy link
Member Author

dustymabe commented Jun 20, 2023 via email

@HuijingHei
Copy link
Contributor

Have no idea how to debug the repo error:

error: Updating rpm-md repo 'rhel-9.2-server-ose-4.14': cannot update repo 'rhel-9.2-server-ose-4.14': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (28): Timeout was reached for http://base-4-14-rhel92.ocp.svc.cluster.local/rhel-9.2-server-ose-4.14/repodata/repomd.xml [Operation too slow. Less than 1000 bytes/sec transferred the last 30 seconds]
error: failed to execute cmd-fetch: exit status 1

@dustymabe
Copy link
Member Author

http://base-4-14-rhel92.ocp.svc.cluster.local

I just don't know why it's trying a repo in a svc.cluster.local domain. Maybe that's the problem?

@cgwalters
Copy link
Member

I just don't know why it's trying a repo in a svc.cluster.local domain.

It's to avoid entitling the Prow hosts; we pull from a proxy mirror today.

@cgwalters
Copy link
Member

Hmm it's weird that this same repo worked in the rhcos metal job.
/retest

@cgwalters
Copy link
Member

Also actually, the scos metal job worked too with the same repo!

I wonder if this is a build system health issue; something about the node on which the build landed not being able to contact the proxy service.

I think given that ci/prow/scos-9-build-test-metal and the other jobs worked, I'm comfortable
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/scos-9-build-test-qemu

In response to this:

Also actually, the scos metal job worked too with the same repo!

I wonder if this is a build system health issue; something about the node on which the build landed not being able to contact the proxy service.

I think given that ci/prow/scos-9-build-test-metal and the other jobs worked, I'm comfortable
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,dustymabe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit becc27e into openshift:master Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@dustymabe: new pull request created: #1319

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants