Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Use 'system-configuration' manifest #512

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

travier
Copy link
Member

@travier travier commented Mar 9, 2021

Packages have been split out from fedora-coreos-base to improve sharing with RHCOS.

@travier
Copy link
Member Author

travier commented Mar 9, 2021

Extra care should be applied here to make sure we are not adding/removing unexpected packages in this PR.

@ashcrow
Copy link
Member

ashcrow commented Mar 9, 2021

 + cosa fetch
fatal: Missing /dev/kvm
error: build error: error building at STEP "RUN /bin/bash -c set -o errexit; umask 0002; ./ci/build-test.sh": error while running runtime: exit status 1 

This is popping up consistently in this repo.

@cgwalters
Copy link
Member

It's #506

@miabbott
Copy link
Member

miabbott commented Mar 9, 2021

/hold

This is in pursuit of adding stalld into RHCOS, but that package won't be included in RHEL until 8.4 GAs

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@travier travier force-pushed the system-configuration branch from 08923b7 to f2fe1d7 Compare March 10, 2021 15:32
@travier
Copy link
Member Author

travier commented Mar 10, 2021

Depends on coreos/fedora-coreos-config#885

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2021
@travier travier force-pushed the system-configuration branch from bbf67b3 to c25f76b Compare March 26, 2021 21:40
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2021
@travier
Copy link
Member Author

travier commented Mar 26, 2021

This includes updates in f-c-c to move stalld back to being FCOS specific until it is included in RHEL.
/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@travier travier force-pushed the system-configuration branch from c25f76b to 600d5c1 Compare March 31, 2021 18:24
@travier
Copy link
Member Author

travier commented Mar 31, 2021

Updated now that coreos/fedora-coreos-config#885 is merged.

@travier
Copy link
Member Author

travier commented Mar 31, 2021

Will have to double check that no package are added or dropped here.

@miabbott
Copy link
Member

miabbott commented Apr 1, 2021

Building HEAD and then the PR shows no package changes:

ostree diff commit from: 3544456bf136761d63a11b89375c38e3f5c5774c2c2af3ab7da2aa0ab60deb02                                                                                                                                                                                                                                     
ostree diff commit to:   738f0359f5885dcf7537ab01c7c231ac883e66c980ec984c2ada075c884448ab
New image input checksum: 1f3e4f5d0c43b64be6cdb2c5d2ff90c29a8192650ad8d21debf5c9790fed0493
None                                                                           
New build ID: 48.83.202104011331-0

@miabbott
Copy link
Member

miabbott commented Apr 1, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@travier
Copy link
Member Author

travier commented Apr 6, 2021

Will be re-updating with coreos/fedora-coreos-config#927

@travier travier force-pushed the system-configuration branch from 600d5c1 to 53f55f9 Compare April 6, 2021 19:21
@travier
Copy link
Member Author

travier commented Apr 6, 2021

Updated. Now requires #527

@travier
Copy link
Member Author

travier commented Apr 13, 2021

Will need either this one or #530 before we branch (for stalld). Edit: We may need both.

travier added 2 commits April 14, 2021 00:27
Packages have been split out from fedora-coreos-base to improve sharing
with RHCOS.
Packages have been split out from fedora-coreos-base to improve sharing
with RHCOS.
@travier travier force-pushed the system-configuration branch from 53f55f9 to 80aa676 Compare April 13, 2021 22:28
@travier
Copy link
Member Author

travier commented Apr 14, 2021

This one should be ready now that #530 is merged.

@miabbott
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4599bdb into openshift:master Apr 14, 2021
@travier travier deleted the system-configuration branch April 14, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants