Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kola: use var-mount test from FCOS #529

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 9, 2021

Now that symlinks are supported, let's do the same thing as #510 for
the var-mount test and dedupe.

Prep for backporting
coreos/fedora-coreos-config#942.

Now that symlinks are supported, let's do the same thing as openshift#510 for
the var-mount test and dedupe.

Prep for backporting
coreos/fedora-coreos-config#942.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021
@arithx
Copy link
Contributor

arithx commented Apr 9, 2021

/approve

@jlebon
Copy link
Member Author

jlebon commented Apr 12, 2021

Blocked on #527

@miabbott
Copy link
Member

/retest

@jlebon
Copy link
Member Author

jlebon commented Apr 13, 2021

Let's merge this? We need it for coverage from the functionality added in #530.

@miabbott
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arithx, jlebon, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6c28ffb into openshift:master Apr 13, 2021
@jlebon jlebon deleted the pr/master branch April 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants