Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay.d: fips: s390x: fix zipl parmfile #565

Closed
wants to merge 2 commits into from
Closed

overlay.d: fips: s390x: fix zipl parmfile #565

wants to merge 2 commits into from

Conversation

madeelibm
Copy link
Contributor

@madeelibm madeelibm commented Jun 18, 2021 •
edited
Loading

This fixes FIPS problem on s390x. The other part needed to make this work is: dracutdevs/dracut#1539

madeelibm added 2 commits June 18, 2021 10:10
@madeelibm
overlay.d: fips: s390x: fix zipl parmfile
b5e41f3 
Zipl expects only kernel command line options in the parmfile.
If a whole bls file is provided as a parmfile, the system will
not be able to boot and switch to rescue mode after reboot.
@madeelibm
overlay.d: fips: s390x: add ignition.firstboot to finish ignition stages
b833457
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: madeelibm
To complete the pull request process, please assign miabbott after the PR has been reviewed.
You can assign the PR to them by writing /assign @miabbott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from ashcrow and miabbott June 18, 2021 08:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

Hi @madeelibm. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2021
@madeelibm madeelibm mentioned this pull request Jun 18, 2021
Merged
@madeelibm madeelibm changed the title Fips support s390x overlay.d: fips: s390x: fix zipl parmfile Jun 18, 2021
@madeelibm
Copy link
Contributor Author

Fix in this PR has been merged in 564, so closing this/redundant one.

@madeelibm madeelibm closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@miabbott miabbott Awaiting requested review from miabbott

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madeelibm