Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AMI/image IDs in preparation for next release #231

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

AlexVulaj
Copy link
Contributor

Updates default AMI IDs and quay image ID to the latest values from Jenkins.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

How to test this PR locally / Special Instructions

Run make build, make test, and the integration tests (see integration/README.md)

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.24%. Comparing base (123c96e) to head (b1d2946).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files          17       17           
  Lines        1358     1358           
=======================================
  Hits          207      207           
  Misses       1137     1137           
  Partials       14       14           
Files Coverage Δ
pkg/verifier/aws/aws_verifier.go 35.66% <ø> (ø)

@rafael-azevedo
Copy link
Contributor

/lgtm

Copy link
Contributor

@rafael-azevedo rafael-azevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6907dda into openshift:main Apr 29, 2024
6 checks passed
@AlexVulaj AlexVulaj deleted the april-2024-release branch April 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants