Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing double sha25 typo #237

Conversation

luis-falcon
Copy link
Contributor

fixing double sha25 typo

@openshift-ci openshift-ci bot requested review from abyrne55 and dakotalongRH May 29, 2024 17:35
Copy link
Contributor

openshift-ci bot commented May 29, 2024

@luis-falcon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.32%. Comparing base (36fadd7) to head (3537302).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   26.32%   26.32%           
=======================================
  Files          11       11           
  Lines        1056     1056           
=======================================
  Hits          278      278           
  Misses        764      764           
  Partials       14       14           
Files Coverage Δ
pkg/verifier/aws/aws_verifier.go 35.66% <ø> (ø)

@abyrne55
Copy link
Contributor

Tested locally and verified new image is being used
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ca5a4d7 into openshift:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants