Rename Probe implementations to be more idiomatic/brief

[abyrne55]

What does this PR do?

This PR renames the curl_json package and both the CurlJSON and Legacy probe implementations such that they can be referred to as curl.Probe and legacy.Probe. It also updates all external (to the probe package) references to those types to use the new names.

This change was originally suggested by @AlexVulaj in a comment on an earlier PR, citing the awkwardness of needing to refer to the probe implementations by names like curl_json.CurlJSONProbe. This suggestion is backed up by Effective Go:

The importer of a package will use the name to refer to its contents, so exported names in the package can use that fact to avoid repetition.... For instance, the buffered reader type in the bufio package is called Reader, not BufReader, because users see it as bufio.Reader, which is a clear, concise name.

As for the renaming of curl_json to curl

By convention, packages are given lower case, single-word names; there should be no need for underscores or mixedCaps... And don't worry about collisions a priori.

This PR doesn't cover docs; those will be updated with OSD-24417. Test names are also not covered (although it does update the error messages in the tests) for the sake of timeliness.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@abyrne55: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.18%. Comparing base (705bbe5) to head (4ae48be).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   31.18%   31.18%           
=======================================
  Files          12       12           
  Lines        1119     1119           
=======================================
  Hits          349      349           
  Misses        752      752           
  Partials       18       18           

Files	Coverage Δ
pkg/probes/curl/curl_json_result.go	96.29% <ø> (ø)
pkg/probes/legacy/legacy.go	89.28% <100.00%> (ø)
pkg/verifier/aws/aws_verifier.go	26.47% <0.00%> (ø)
pkg/probes/curl/curl_json.go	75.94% <50.00%> (ø)

[AlexVulaj]

/lgtm

[AlexVulaj]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AlexVulaj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment