Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune polling intervals for an overall faster ValidateEgress() #260

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

abyrne55
Copy link
Contributor

@abyrne55 abyrne55 commented Aug 1, 2024

What does this PR do? / Related Issues / Jira

This PR speeds up ValidateEgress() but adjusting how often we're checking for serial console output (i.e., "the PollImmediate() loop") and if the EC2 instance has finished terminating. This means that we'll spend less time unnecessarily waiting if, e.g., an instance finishes terminating after 17 seconds, as the previous config would only have checked once at 15s and again at 30s, whereas this new config will check at 3s, 6s, 9s... 15s, and 18s.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against aws, it doesn't cause any regression
  • [ ] I have added execution results to the PR's readme

How to test this PR locally / Special Instructions

Keep an eye out for previously unforeseen race conditions or API ratelimiting (unlikely given the still-long intervals). Otherwise, please test this PR as you would any other verifier PR.

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

@abyrne55: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot requested review from AlexVulaj and reedcort August 1, 2024 18:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.82%. Comparing base (8024971) to head (a9d80be).

Files Patch % Lines
pkg/clients/aws/aws.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   24.85%   24.82%   -0.03%     
==========================================
  Files          23       23              
  Lines        1738     1740       +2     
==========================================
  Hits          432      432              
- Misses       1284     1286       +2     
  Partials       22       22              
Files Coverage Δ
pkg/verifier/aws/aws_verifier.go 35.94% <100.00%> (ø)
pkg/clients/aws/aws.go 8.33% <0.00%> (-0.24%) ⬇️

Copy link
Contributor

@rafael-azevedo rafael-azevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 87b6710 into openshift:main Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants