Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSD-25868: Adds aws-hosted-cp as a valid Platform name #275

Merged
merged 2 commits into from
Oct 3, 2024
Merged

OSD-25868: Adds aws-hosted-cp as a valid Platform name #275

merged 2 commits into from
Oct 3, 2024

Conversation

joshbranham
Copy link
Contributor

@joshbranham joshbranham commented Oct 3, 2024 •
edited
Loading

What does this PR do? / Related Issues / Jira

This extends the Platform structs to accept aws-hosted-cp as a valid value for looking up AWSHCP ByName(). This value is used internally still and blocks integrating the updated verifier.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

Reviewer's Checklist

  • (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

@joshbranham
OSD-25868: Adds aws-hosted-cp as a valid Platform name
0daf174 
This extends the Platform structs to accept `aws-hosted-cp` as a valid value for looking up
AWSHCP `ByName()`. This value is used internally still and blocks integrating the updated
verifier.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2024 •
edited by openshift-ci bot
Loading

@joshbranham: This pull request references OSD-25868 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

What does this PR do? / Related Issues / Jira

This extends the Platform structs to accept aws-hosted-cp as a valid value for looking up AWSHCP ByName(). This value is used internally still and blocks integrating the updated verifier.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

Reviewer's Checklist

  • (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2024 •
edited by openshift-ci bot
Loading

@joshbranham: This pull request references OSD-25868 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

What does this PR do? / Related Issues / Jira

This extends the Platform structs to accept aws-hosted-cp as a valid value for looking up AWSHCP ByName(). This value is used internally still and blocks integrating the updated verifier.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

Reviewer's Checklist

  • (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from lnguyen1401 and reedcort October 3, 2024 16:21
abyrne55
abyrne55 suggested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@abyrne55 abyrne55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, just requested an additional test case

pkg/data/cloud/platform_test.go Show resolved Hide resolved
abyrne55
abyrne55 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@abyrne55 abyrne55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with ./osd-network-verifier egress --platform=aws-hosted-cp and confirmed new alias selects the aws-hcp egress list as expected. Also tested --platform="" and confirmed error.

Nice work, @joshbranham!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@abyrne55
Copy link
Contributor

abyrne55 commented Oct 3, 2024

/test all

@openshift-merge-bot openshift-merge-bot bot merged commit 30238fb into openshift:main Oct 3, 2024
6 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joshbranham joshbranham deleted the extend-platform-aliases branch October 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abyrne55 abyrne55 abyrne55 approved these changes

@lnguyen1401 lnguyen1401 Awaiting requested review from lnguyen1401

@reedcort reedcort Awaiting requested review from reedcort

Assignees

@abyrne55 abyrne55

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshbranham @openshift-ci-robot @abyrne55