Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the comments for the ensurePrivate flag #278

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bmeng
Copy link
Contributor

@bmeng bmeng commented Oct 8, 2024

What does this PR do? / Related Issues / Jira

doc update

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

Reviewer's Checklist

  • (This needs to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

Logs

@openshift-ci openshift-ci bot requested review from abyrne55 and lnguyen1401 October 8, 2024 07:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.91%. Comparing base (97baeb6) to head (a6cc72d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   25.91%   25.91%           
=======================================
  Files          25       25           
  Lines        1837     1837           
=======================================
  Hits          476      476           
  Misses       1333     1333           
  Partials       28       28           
Files with missing lines Coverage Δ
pkg/probes/curl/curl_json.go 83.00% <ø> (ø)
pkg/verifier/aws/entry_point.go 0.00% <ø> (ø)

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@bmeng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@abyrne55 abyrne55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks so much for following up on this, @bmeng! Looks great ☺️

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c1120ad into openshift:main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants