Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional 'escape routes' to proxied VPC terraform examples #281

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

abyrne55
Copy link
Contributor

@abyrne55 abyrne55 commented Oct 25, 2024

This PR adds optional "escape routes" to the proxied VPC terraform scripts under examples/aws/terraform/. I used this to test the --no-proxy feature added in #280. This feature allows us to simulate customer networks that have NO_PROXY routes to external services (e.g., splunk).

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested the functionality against gcp / aws, it doesn't cause any regression
  • I have added execution results to the PR's readme

How to test this PR locally / Special Instructions

Follow the instructions in both READMEs, and be sure to set a value for the proxied_subnet_escape_routes variable in your terraform.tfvars. If you use the provided bash one-liner to get all the Splunk IPs, you'll be able to run the verifier on the proxied subnet (using the instructions in the READMEs, incl. the bit about downloading the CA cert) and pass all checks, even for Splunk.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@abyrne55 abyrne55 marked this pull request as ready for review October 25, 2024 21:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@abyrne55: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.79%. Comparing base (d86f9d5) to head (edf1453).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   25.91%   25.79%   -0.12%     
==========================================
  Files          25       26       +1     
  Lines        1837     1845       +8     
==========================================
  Hits          476      476              
- Misses       1333     1341       +8     
  Partials       28       28              

see 4 files with indirect coverage changes

Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@abyrne55
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9301ae4 into openshift:main Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants