-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional 'escape routes' to proxied VPC terraform examples #281
Add optional 'escape routes' to proxied VPC terraform examples #281
Conversation
Skipping CI for Draft Pull Request. |
@abyrne55: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 25.91% 25.79% -0.12%
==========================================
Files 25 26 +1
Lines 1837 1845 +8
==========================================
Hits 476 476
- Misses 1333 1341 +8
Partials 28 28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyrne55, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds optional "escape routes" to the proxied VPC terraform scripts under
examples/aws/terraform/
. I used this to test the--no-proxy
feature added in #280. This feature allows us to simulate customer networks that haveNO_PROXY
routes to external services (e.g., splunk).Checklist
How to test this PR locally / Special Instructions
Follow the instructions in both READMEs, and be sure to set a value for the
proxied_subnet_escape_routes
variable in your terraform.tfvars. If you use the provided bash one-liner to get all the Splunk IPs, you'll be able to run the verifier on the proxied subnet (using the instructions in the READMEs, incl. the bit about downloading the CA cert) and pass all checks, even for Splunk.