Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-26236 leaver process member removal #289

Conversation

luis-falcon
Copy link
Contributor

@luis-falcon luis-falcon commented Nov 18, 2024

Removing michael shen from OWNER FILE as part of the leaver process

Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@luis-falcon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.18%. Comparing base (c90ca57) to head (48189a8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   28.18%   28.18%           
=======================================
  Files          26       26           
  Lines        1845     1845           
=======================================
  Hits          520      520           
  Misses       1293     1293           
  Partials       32       32           
---- 🚨 Try these New Features:

@openshift-merge-bot openshift-merge-bot bot merged commit 3cd775d into openshift:main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants