OSD-20509: Updates infra resize command to add SL for GCP #532
Conversation
for OSD-20509
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Added the managed notification link
Co-authored-by: Pratik Panda <pratikpanda24@gmail.com>
|
/retest |
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
openshift-ci
bot
changed the title
|
/retitle OSD-20509: Updates infra resize command to add SL for GCP |
openshift-ci
bot
changed the title
|
/unhold |
openshift-ci-robot
added
the
jira/valid-reference
|
@PriyankaKanthale94: This pull request references OSD-20509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
| twentyMinuteTimeout = 20 * time.Minute | ||
| twentySecondIncrement = 20 * time.Second | ||
| resizedInfraNodeServiceLogTemplate = "https://raw.githubusercontent.com/openshift/managed-notifications/master/osd/infranode_resized_auto.json" | ||
| GCPresizedInfraNodeServiceLogTemplate = "https://raw.githubusercontent.com/openshift/managed-notifications/master/osd/gcp/GCP_infranode_resized_auto.json" |
There was a problem hiding this comment.
I don't think the service log listed here as "GCP" is any better - the documentation it links to still only talks about ROSA
There was a problem hiding this comment.
@mjlshen GCP SL points to OSD documentation not the ROSA documentation. We do not have a separate documentation for GCP on OSD. AWS on OSD and GCP on OSD are in single documentation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devppratik, mjlshen, PriyankaKanthale94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@PriyankaKanthale94: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
for OSD-20509