refactor infra node resizing command to allow moving resize-control-plane-node #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lane-node Signed-off-by: Michael Shen <mshen@redhat.com>
openshift-ci
bot
added
the
approved
|
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OSD-23315 the overall plan is to add CPMS-aware control plane resizing to osdctl.
This PR renames the
Resizestruct toInfrain preparation to add aControlPlanestruct for resizing control planes, the next PR will move the existing resize control plane command underneathosdctl cluster resize, and finally I will be adding a--cpmsflag so that we can start gathering (opt-in) data on CPMS-assisted resizes.At a future date, outside the scope of OSD-23315, the
--cpmsflag should be come default behavior and the legacy process of resizing one node at a time can be deprecated and removed.