Add warning to network verification that HCPs are unsupported. #579
Conversation
Its not widely know, that network verifier is unable to run against HCPs. This can lead to red herring situations and a warning is needed.
| @@ -218,6 +219,12 @@ func (e *EgressVerification) setup(ctx context.Context) (*aws.Config, error) { | |||
| e.log.Debug(ctx, "cluster %s found from OCM: %s", e.ClusterId, cluster.ID()) | |||
| e.cluster = cluster | |||
|
|
|||
| if e.cluster.Hypershift().Enabled() { | |||
There was a problem hiding this comment.
Small conversation about this here: https://redhat-internal.slack.com/archives/CMD1L32M9/p1717424955110269
We may want to additionally
- Take that bash script and just make it a new osdctl command (for another PR, not here 😄 )
- Leave comments here explaining why HCPs aren't supported, and when we can remove this block of code
There was a problem hiding this comment.
Good suggestions thanks! Will add the info from the thread.
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
@RaphaelBut: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, mjlshen, RaphaelBut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Its not widely known, that network verifier is unable to run against HCPs.
This can lead to red herring situations and a warning is needed.
This is a follow up item from PMR 75 https://issues.redhat.com/browse/OSD-23785