Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSD-25695 - Remove Deprecated Cluster ID (-C) from Account Console Command #612

Merged
merged 1 commit into from
Oct 11, 2024
Merged

OSD-25695 - Remove Deprecated Cluster ID (-C) from Account Console Command #612

merged 1 commit into from
Oct 11, 2024

Conversation

dustman9000
Copy link
Member

@dustman9000 dustman9000 commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

Removes deprecated command and option from osdctl for accessing AWS accounts via Cluster ID. Backplane is now the preferred method of accessing accounts via Cluster ID.

OSD-25695

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@dustman9000
Copy link
Member Author

/hold as this might need further discussion for MC access

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@typeid
Copy link
Member

typeid commented Sep 24, 2024

@dustman9000 what stops us from using osdctl account console -i <mc_aws_account_id> -p rhcontrol to access MC consoles via OrganizationAccessRole? I have only ever used that, so lgtm.

/lgtm
/approve

typeid
typeid approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devppratik
Copy link
Contributor

Removing the hold based on @typeid 's comment above

@devppratik
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cbfdb2e into openshift:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typeid typeid typeid approved these changes

@clcollins clcollins Awaiting requested review from clcollins

@mjlshen mjlshen Awaiting requested review from mjlshen

Assignees

@typeid typeid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dustman9000 @typeid @devppratik