cni: update MCS-blocking code to do both IPv4 and IPv6 #144
Conversation
openshift-ci-robot
added
the
approved
|
@celebdor: GitHub didn't allow me to request PR reviews from the following users: kirankt. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I saw that openshift/sdn blocks it at the node level for hostnetworking pods. Is it something ovn-kubernetes should be covering for as well? |
| } | ||
| } | ||
| if hasIPv6 { | ||
| out, err := exec.Command("ip6tables", args...).CombinedOutput() |
There was a problem hiding this comment.
You're getting lucky here, because ipv4 addresses (line ~233) also happen to parse as ipv6 addresses. I think you'll need separate list of family-agnostic and -non-agnostic rules.
There was a problem hiding this comment.
@squeed fixed. can you re-review?
danwinship
force-pushed
the
ipv6-mcs-blocking
branch
from
32c7e4b
to
114ac7a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
noticed by @celebdor
/assign @dcbw
Also fixed failure-to-do-MCS-blocking to be a fatal pod error rather than just a warning. And for the same reason, I made the IPv4 and IPv6 sections conditional on whether we are using IPv4/IPv6, since you don't want to block IPv4-only pods because we couldn't create ip6tables rules.