Machine api operator #1095

paulfantom · 2018-07-25T13:37:40Z

Implement simple test and build pipeline for machine-api-operator repository. To stay as close as possible to developer workflow, make command is used to build binary.

@smarterclayton this will also need a place to store images? Can I expect new repository in deocker hub or quay to be set up?

paulfantom · 2018-07-26T14:22:48Z

@bbguimaraes could you take a look at this?

smarterclayton · 2018-07-26T15:26:34Z

cluster/ci/config/prow/config.yaml

@@ -4179,6 +4182,35 @@ postsubmits:
        - --target=[images]
        - --promote

+  openshift/machine-api-operator:


Add a PR job that also builds the images, that way we know that it works (the problem with branch only jobs is that if they fail they fail silently)

Since this should also build images, I changed name.

Go ahead and add the PR job that builds the images as well (so put it in presubmits, copy one of the existing ones that has --target=[images] --target=unit

I have added another job called pull-ci-openshift-machine-api-operator-unit and based on pull-ci-kubernetes-coredns-unit.

smarterclayton · 2018-07-26T15:26:58Z

cluster/ci/config/prow/config.yaml

    labels:
    - lgtm
    missingLabels:
    - needs-ok-to-test
    - do-not-merge/work-in-progress
    - do-not-merge/hold
+  merge_method:
+    openshift/machine-api-operator: squash


Do you know if this has been tested with batch merges? I'm not familiar with this and I know most prow users don't use it, so I don't want you to hit surprising and magic bugs.

Thi is used by upstream, but I will drop it from here.

https://github.com/kubernetes/test-infra/blob/fc2bb229415d184fe0355cc39ed804b81d9907a7/prow/config.yaml#L293

smarterclayton · 2018-07-26T15:27:15Z

ci-operator/config/openshift/machine-api-operator/master.json

+      "requests": { "cpu": "100m", "memory": "200Mi" },
+      "limits":   { "cpu": "2",    "memory": "4Gi" }
+    },
+    "bin": {


I don't think you need this much CPU, you can probably drop both bin and unit for now unless you have data otherwise.

Yeah, that was a copy paste. Reduced.

I meant remove the bin and unit sections - the "*" section already provides defaults, that way you don't have to do it per container.

Sorry, I misunderstood you. Fixed.

smarterclayton · 2018-07-27T15:05:50Z

cluster/ci/config/prow/config.yaml

+        - --target=[images]
+        - --promote
+
+  - name: pull-ci-openshift-machine-api-operator-unit


This needs to be under "presubmits" (with other PR jobs) and the branch job should be under "postsubmits". The section you are in determines when you are called.

dgoodwin · 2018-08-10T12:15:59Z

bump! how are things looking on this @smarterclayton (or possibly @stevekuznetsov )

paulfantom · 2018-08-13T12:15:06Z

I have migrated presubmits and postsubmits configuration from config.yml file to separate files following practices from master branch.

@stevekuznetsov @smarterclayton could you review this?

smarterclayton · 2018-08-13T17:54:53Z

/lgtm

openshift-ci-robot · 2018-08-13T17:59:06Z

@paulfantom: Updated the plugins configmap using the following files:

key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

Implement simple test and build pipeline for machine-api-operator repository. To stay as close as possible to developer workflow, make command is used to build binary.

@smarterclayton this will also need a place to store images? Can I expect new repository in deocker hub or quay to be set up?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2018

paulfantom force-pushed the machine-api-operator branch from e73a5c2 to 81f7a71 Compare July 26, 2018 14:13

paulfantom changed the title ~~WIP: Machine api operator~~ Machine api operator Jul 26, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2018

smarterclayton reviewed Jul 26, 2018

View reviewed changes

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2018

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2018

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2018

paulfantom force-pushed the machine-api-operator branch from 6a29cb7 to 650689b Compare July 27, 2018 08:45

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 27, 2018

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2018

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2018

paulfantom force-pushed the machine-api-operator branch from 73ed376 to f946d7b Compare July 27, 2018 09:00

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2018

smarterclayton reviewed Jul 27, 2018

View reviewed changes

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2018

paulfantom force-pushed the machine-api-operator branch from 05f661c to e306002 Compare August 7, 2018 06:50

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2018

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2018

paulfantom added 3 commits August 13, 2018 14:08

configure ci for machine-api-operator

c357acd

reduce resources; drop squash merging method; build images in job

dbdd06b

add unit build; drop unnecessary resource configuration

2565066

paulfantom force-pushed the machine-api-operator branch from e306002 to 2565066 Compare August 13, 2018 12:09

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2018

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2018

migrate presubmits and postsubmits for openshift/machine-api-operator

71ee4a3

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2018

openshift-ci-robot assigned smarterclayton Aug 13, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018

openshift-merge-robot merged commit f321b70 into openshift:master Aug 13, 2018

paulfantom deleted the machine-api-operator branch November 29, 2018 13:11

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023

Remove wait for ironic service (openshift#1095)

6fc7eaa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Machine api operator #1095

Machine api operator #1095

paulfantom commented Jul 25, 2018 •

edited

Loading

paulfantom commented Jul 26, 2018

smarterclayton Jul 26, 2018

paulfantom Jul 26, 2018

smarterclayton Jul 26, 2018

paulfantom Jul 27, 2018

smarterclayton Jul 26, 2018

paulfantom Jul 26, 2018 •

edited

Loading

smarterclayton Jul 26, 2018

paulfantom Jul 26, 2018

smarterclayton Jul 26, 2018

paulfantom Jul 27, 2018

smarterclayton Jul 27, 2018

paulfantom Aug 7, 2018

dgoodwin commented Aug 10, 2018

paulfantom commented Aug 13, 2018

smarterclayton commented Aug 13, 2018

openshift-ci-robot commented Aug 13, 2018

Machine api operator #1095

Machine api operator #1095

Conversation

paulfantom commented Jul 25, 2018 • edited Loading

paulfantom commented Jul 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulfantom Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgoodwin commented Aug 10, 2018

paulfantom commented Aug 13, 2018

smarterclayton commented Aug 13, 2018

openshift-ci-robot commented Aug 13, 2018

paulfantom commented Jul 25, 2018 •

edited

Loading

paulfantom Jul 26, 2018 •

edited

Loading