Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync prow configuration with latest changes from test-infra #120

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Sync prow configuration with latest changes from test-infra #120

merged 1 commit into from
Sep 4, 2017

Conversation

0xmichalis
Copy link
Contributor

Contains new /shrug and /hold plugins

@stevekuznetsov fyi

Contains new /shrug and /hold plugins

Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
@0xmichalis 0xmichalis merged commit 513ede5 into openshift:master Sep 4, 2017
@0xmichalis 0xmichalis deleted the update-prow-config branch September 4, 2017 10:50
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2017
@stevekuznetsov
Copy link
Contributor

We can do WIP label too, need to make labels for it is all

wking added a commit to wking/openshift-release that referenced this pull request Aug 29, 2018
Cover ./pkg/... (and, for go-lint, ./cmd/...).  These directories are
new with openshift/installer@4e92db8 (Merge pull request openshift#120 from
staebler/asset_graph_engine, 2018-08-24, openshift/installer#120).

There's no particular reason to not run the Go unit tests on ./cmd/...
But we're unlikely to have unit tests there, and the old tests
restricted themselves to ./installer/pkg/..., so I've stuck with that
pattern here.

Steve recommended using 'go list ...' to run the lint commands [1].
We just want something that will give us our Go directories without
dropping down into the vendor directories.

[1]: openshift#1289 (comment)
droslean pushed a commit to droslean/release that referenced this pull request Jan 14, 2022
Add the deployer prow plugin manifest files and configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants