Bug 1882855: ci-operator/step-registry/ipi/conf/aws/blackholenetwork: Add ELB endpoint #12263
Conversation
openshift-ci-robot
added
the
bugzilla/severity-low
|
@wking: This pull request references Bugzilla bug 1882855, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/hold I've pushed this out into production; wait until we see it working before we land this. |
openshift-ci-robot
added
the
do-not-merge/hold
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-aws-proxy/1309954993431777280/artifacts/e2e-aws-proxy/gather-extra/machines.json | jq -r '.items[].status.no
deRef.name'
ip-10-0-61-156.us-west-2.compute.internal
ip-10-0-67-84.us-west-2.compute.internal
ip-10-0-60-108.us-west-2.compute.internal
ip-10-0-55-52.us-west-2.compute.internal
ip-10-0-60-110.us-west-2.compute.internal
ip-10-0-76-249.us-west-2.compute.internal/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
…oint Like ae4da13 (ci-operator/step-registry/ipi/conf/aws/blackholenetwork/blackhole_vpc_yaml: Add EC2 endpoint, 2020-09-09, openshift#11723), but for load balancers. Docs [1,2]. Rolled out using the same shell commands from the ae4da13 commit message. The machine API provider needs this for something [3] and doesn't respect the Proxy config yet [4]. [1]: https://docs.aws.amazon.com/elasticloadbalancing/latest/userguide/load-balancer-vpc-endpoints.html [2]: https://docs.aws.amazon.com/vpc/latest/userguide/endpoint-service.html [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1882855#c1 [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1769223
wking
force-pushed
the
blackhole-elb-vpc-endpoint
branch
from
c80ff16
to
48dd599
Compare
|
@wking this seems good to me, are you wanting to move this forward? |
Yup. Per my previous comment, I think this is ready to land. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1882855 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Like ae4da13 (#11723), but for load balancers. Docs here and here. Rolled out using the same shell commands from the ae4da13 commit message. The machine-API provider needs this for something and doesn't respect the Proxy config yet.