core-services/prow/02_config/_boskos: Shard AWS, Azure, and GCP by region #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
alvaroaleman
reviewed
Oct 9, 2020
wking
force-pushed
the
per-region-leases
branch
from
61e9a5a
to
ef394fa
Compare
wking
force-pushed
the
per-region-leases
branch
from
ef394fa
to
9c2288e
Compare
wking
force-pushed
the
per-region-leases
branch
from
9c2288e
to
0a4f1a7
Compare
The names are used for custom resources, so we need unique names for each entry [1]. Consuming jobs will have to split on the --, which is hopefully unique enough, to get the raw name (if they plan to use it to select a region or similar). I'm not using '-', because: a. I wanted to avoid enumerating single-count entries. b. I wanted consumers to not have to care about whether they were drawing from a single-count or multi-count entry. Using a separator that is not part of the raw names means that consumers can always split on that separator without having to worry about whether they were drawing from a single-count or a multi-count name. [1]: openshift#12589 (comment)
…gion With some guessing about what we support. No consumers yet, but consumer rehearsals run against the production Boskos server [1], so we need to land these before we can consume them. [1]: openshift#12584 (comment)
wking
force-pushed
the
per-region-leases
branch
from
0a4f1a7
to
0cb81d0
Compare
wking
added a commit
to wking/ci-tools
that referenced
this pull request
Oct 14, 2020
To allow for the suffixed lease names from [1] without exposing the suffixes to consuming steps. [1]: openshift/release#12589
alvaroaleman
approved these changes
Oct 14, 2020
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like the local consumers are all |
|
4h since my last comment. Surely it has made it over by now, and even if it hasn't, nobody is consuming the /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 15, 2020
…CP by region" This reverts commit 0cb81d0, openshift#12589. Telemetry isn't showing any free leases on these platforms, which is freaking me out a bit. It's possible that the dashboards just don't handle static names gracefully, but I'm going to float a revert in case something breaks and we want to buy some time for a post-mortem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some guessing about what we support. No consumers yet, but consumer rehearsals run against the production Boskos server, so we need to land these before we can consume them.