-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow conf workernode #14350
Allow conf workernode #14350
Conversation
992a1af
to
378696e
Compare
/assign @wking |
@@ -3,6 +3,12 @@ chain: | |||
steps: | |||
- chain: ipi-conf-aws | |||
- chain: ipi-install | |||
env: | |||
- name: COMPUTE_NODE_TYPE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go on the *-ref.yaml
step, not the chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wking better?
378696e
to
ef84e60
Compare
CI looks green enough. From this run: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/14350/rehearse-14350-pull-ci-open-cluster-management-registration-operator-master-e2e/1338945605858234368/artifacts/e2e/gather-extra/nodes.json | jq -r '.items[].metadata.labels["node.kubernetes.io/instance-type"]' | sort | uniq -c
3 m5.large
3 m5.xlarge |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcantrill: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jcantrill: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR allows setting compute instance type for cases where larger compute nodes are required.
Partially resolves https://issues.redhat.com/browse/DPTP-1740
Replaces #13712