Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conf workernode #14350

Merged

Conversation

jcantrill
Copy link
Contributor

This PR allows setting compute instance type for cases where larger compute nodes are required.

Partially resolves https://issues.redhat.com/browse/DPTP-1740

Replaces #13712

@jcantrill
Copy link
Contributor Author

/assign @wking

@@ -3,6 +3,12 @@ chain:
steps:
- chain: ipi-conf-aws
- chain: ipi-install
env:
- name: COMPUTE_NODE_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on the *-ref.yaml step, not the chain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking better?

@wking
Copy link
Member

wking commented Dec 15, 2020

CI looks green enough. From this run:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/14350/rehearse-14350-pull-ci-open-cluster-management-registration-operator-master-e2e/1338945605858234368/artifacts/e2e/gather-extra/nodes.json | jq -r '.items[].metadata.labels["node.kubernetes.io/instance-type"]' | sort | uniq -c
      3 m5.large
      3 m5.xlarge

@wking
Copy link
Member

wking commented Dec 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@openshift-merge-robot
Copy link
Contributor

@jcantrill: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 378696e880ecfe7d01bcdb25b6dbea141f9acade link /test pj-rehearse
ci/rehearse/open-cluster-management/registration-operator/master/e2e ef84e60 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-aws-ovn-windows ef84e60 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-aws-ovn-windows-custom-vxlan ef84e60 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/release-1.2/hco-e2e-image-index-aws ef84e60 link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.2/e2e-cmd ef84e60 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-shared-vpc ef84e60 link /test pj-rehearse
ci/rehearse/openshift/cincinnati/master/e2e ef84e60 link /test pj-rehearse
ci/rehearse/ComplianceAsCode/content/master/e2e-aws-ocp4-cis-node ef84e60 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4c4b5f0 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@jcantrill: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key ipi-conf-aws-commands.sh using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
    • key ipi-conf-aws-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-ref.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ipi-conf-aws-commands.sh using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
    • key ipi-conf-aws-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-ref.yaml

In response to this:

This PR allows setting compute instance type for cases where larger compute nodes are required.

Partially resolves https://issues.redhat.com/browse/DPTP-1740

Replaces #13712

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants