Add 4.8 and change master to 4.9 #19435
Conversation
- Since 4.9 is not yet in place the tag for master still 4.8 for now Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
|
/lgtm Thanks for working on this @ravanelli! |
|
@jlebon Would you mind taking a look on that? |
There was a problem hiding this comment.
One nit, but LGTM overall. Not super familiar with Prow-speak though so leaving it to @cgwalters to have a look and do the stamping.
| @@ -1,5 +1,5 @@ | |||
| base_images: | |||
| coreos_coreos-assembler_48: | |||
| coreos_coreos-assembler_49: | |||
There was a problem hiding this comment.
Seems like this should just be called coreos_coreos-assembler_latest instead, no? There is no 4.9 cosa yet so this is misleading.
Or actually, since we have to keep using the 4.8 image for now until we fix openshift/os#552, maybe better to just not touch this file at all. (But then eventually once we do fix that, it'd be coreos_coreos-assembler_latest here and tag: "latest" below.)
There was a problem hiding this comment.
@jlebon meh, it got merged already. Let me know what do you think, if should I change it following the comments above.
There was a problem hiding this comment.
That's OK, I'm sure we'll keep tweaking these settings in the future as we sort everything out.
Thanks a lot for looking at this!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkmuggle, jlebon, ravanelli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ravanelli: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Renata Ravanelli rravanel@redhat.com