ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Drop IMAGE_FORMAT #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XS
wking
force-pushed
the
drop-installer-e2e-unused-image-format
branch
from
6fc6154
to
f100e17
Compare
This image has been unused since the e2e template landed in 51df634 (Support an aws installer CI job, 2018-06-07, openshift#928) and since the Ansible template landed in c35a30a (Add a profile openshift-ansible custom AWS provisioner, 2018-08-30, openshift#1367). Also remove the duplicated entry from the src template which landed in aed67fc (Source installer tests should have access to IMAGE_FORMAT, 2019-01-25, openshift#2701).
wking
force-pushed
the
drop-installer-e2e-unused-image-format
branch
from
f100e17
to
f88b94e
Compare
openshift-ci-robot
removed
the
approved
|
Rebased around #2911 and picked up the Ansible template with f100e17 -> f88b94e. Ping @bbguimaraes, since you approved #1367 ;). |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@wking: Updated the following 6 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 1, 2019
…-40: Drop IMAGE_FORMAT Like f88b94e (ci-operator/templates/openshift/installer: Drop IMAGE_FORMAT, 2019-02-19, openshift#2910), but for the template that just came in (without using IMAGE_FORMAT) in e638cc3 (BYOR 4.0: add a template to test scaleup, 2019-01-18, openshift#2637).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This image has been unused since the template landed in 51df634 (#928).