release-controller: Treat rhel-coreos-8 the same as machine-os-content
#31083
Conversation
…tent` The former is going to replace the latter. See https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering.md I'm *hoping* this is somehow what's necessary to have the image that is now built by ART included in the CI payload, so that we can get this PR to work: openshift/machine-config-operator#3258 (comment)
|
I don't think this change will do what you're actually trying to achieve, but it still LGTM, as we don't want to mirror the rhel oscontainer from the ocp namespace to the origin ns (we'll obviously want to build FCOS/SCOS oscontainers directly to the origin ns as replacements instead). From my admittedly limited understanding of the Prow CI release controller, the /approve |
|
Yeah, thanks I think you're right! Clearly this whole thing raises the issue of whether ci uses fcos/scos9 but I don't think we can pull the trigger on that right now (unless we add scos8, but even then). |
|
Let's get this in. /assign @bradmwilliams Could you take a look? Edit: @cgwalters re the question whether fcos or scos is used in OKD CI: FCOS for now, but we'll soon rename the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, cgwalters, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision 0f66edf was retested 9 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
@cgwalters this change requires an update to the mapping file: |
|
I'm folding this into #31663 /close |
|
@LorbusChris: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The former is going to replace the latter. See
https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering.md
I'm hoping this is somehow what's necessary to have the image
that is now built by ART included in the CI payload, so that
we can get this PR to work:
openshift/machine-config-operator#3258 (comment)