Skip to content

[WIP] NO-ISSUE: test ccm vsphere internal cidr #43131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[WIP] NO-ISSUE: test ccm vsphere internal cidr #43131

wants to merge 5 commits into from

Conversation

@rbbratta
Copy link
Contributor

@rbbratta rbbratta commented Sep 7, 2023

set cluster-infrastructure vshpere internal cidr

@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Sep 7, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 7, 2023

@rbbratta: This pull request references Jira Issue OCPBUGS-18641, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

set cluster-infrastructure vshpere internal cidr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 7, 2023
@openshift-ci openshift-ci bot requested review from danwinship and neisw September 7, 2023 23:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbbratta
Once this PR has been reviewed and has the lgtm label, please assign deads2k, knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from dae32f8 to f274e3d Compare September 8, 2023 00:03
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

1 similar comment
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 4659619 to 57b1aaf Compare September 8, 2023 01:47
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 57b1aaf to 65a180c Compare September 8, 2023 03:02
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@elmiko
Copy link
Contributor

elmiko commented Sep 8, 2023

thanks for setting this up @rbbratta !

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 65a180c to 66aa952 Compare September 8, 2023 14:02
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 66aa952 to 9c6b079 Compare September 8, 2023 14:05
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 9c6b079 to 2c61f5e Compare September 8, 2023 15:45
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 2c61f5e to eb553aa Compare September 8, 2023 16:42
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from eb553aa to 9c0662a Compare September 8, 2023 21:31
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 8, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 9c0662a to 9b33cb4 Compare September 8, 2023 21:35
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 11, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from 5d4013e to f113db6 Compare September 11, 2023 23:23
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 11, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 11, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from bcdb971 to cc5af28 Compare September 12, 2023 03:00
@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 12, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

@rbbratta rbbratta force-pushed the OCPBUGS-18641-ccm-internal-cidr branch from cc5af28 to a6d7497 Compare September 12, 2023 14:06
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2023

[REHEARSALNOTIFIER]
@rbbratta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-unit-tests kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-go-tests kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-rhel7 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-rhel8 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-rhel9 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-windows10 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-windows11 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-windows2016 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-windows2019 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-windows2022 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-fedora kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-ubuntu kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-centos6 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-centos7 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-centos-stream8 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-centos-stream9 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-master-e2e-gcp-common-templates-opensuse kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-unit-tests kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-rhel6 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-rhel7 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-rhel8 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-windows10 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-windows2012 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-windows2016 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-windows2019 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-fedora kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-ubuntu kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-centos6 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-centos7 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-centos8 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.13-e2e-gcp-nested-common-templates-opensuse kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.16-e2e-gcp-common-templates-unit-tests kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.16-e2e-gcp-go-tests kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.16-e2e-gcp-common-templates-rhel6 kubevirt/common-templates presubmit Registry content changed
pull-ci-kubevirt-common-templates-release-v0.16-e2e-gcp-common-templates-rhel7 kubevirt/common-templates presubmit Registry content changed

A total of 11179 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

@rbbratta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-network-operator/master/e2e-vsphere-ovn-dualstack eb553aa54ee3142120b20e2412329630c7746af8 link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack
ci/rehearse/openshift/cluster-network-operator/release-4.14/e2e-vsphere-ovn-dualstack cc5af28594e68c8cf345dd4a0d89b5cc674e4bca link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 27, 2023
Merged
@mkowalski
Copy link
Contributor

mkowalski commented Sep 27, 2023

/retitle [WIP] NO-ISSUE: test ccm vsphere internal cidr

Retitling because Jira cannot move forward even though the original PR that fixes the issue has merged

@openshift-ci openshift-ci bot changed the title [WIP] OCPBUGS-18641: test ccm vsphere internal cidr [WIP] NO-ISSUE: test ccm vsphere internal cidr Sep 27, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2023

@rbbratta: This pull request explicitly references no jira issue.

In response to this:

set cluster-infrastructure vshpere internal cidr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rbbratta
Copy link
Contributor Author

rbbratta commented Sep 27, 2023

not needed for now, openshift/cluster-cloud-controller-manager-operator#279 fixed this.

@rbbratta rbbratta closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@neisw neisw Awaiting requested review from neisw

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbbratta @openshift-ci-robot @elmiko @mkowalski