Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix odh upstream main notebooks configuration #44716

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix odh upstream main notebooks configuration #44716

merged 1 commit into from
Oct 23, 2023

Conversation

atheo89
Copy link
Contributor

@atheo89 atheo89 commented Oct 23, 2023

Fix the ODH upstream main notebooks configuration by removing PyTorch and TensorFlow ubi8 artifacts

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@atheo89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-notebooks-main-habana-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-images opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-codeserver-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-11-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-9-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-rstudio-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-pytorch-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-pytorch-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@atheo89
Copy link
Contributor Author

atheo89 commented Oct 23, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 23, 2023
@atheo89 atheo89 mentioned this pull request Oct 23, 2023
Merged
3 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@atheo89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

harshad16
harshad16 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@atheo89
Copy link
Contributor Author

atheo89 commented Oct 23, 2023

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 959996e into openshift:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@rkpattnaik780 rkpattnaik780 Awaiting requested review from rkpattnaik780

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atheo89 @openshift-ci-robot @harshad16