-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand AWS e2e cluster across 3 availability zones #5047
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
any thoughts here? |
/assign @wking @abhinavdahiya |
#3615 explains why we dropped us-east-1c. I'm still concerned about the throttling impact of restoring it. Maybe after we shard over AWS regions or otherwise grow some AWS-throttling headroom? |
I see. If nothing has changed, then the throttling situation will likely be worse now that there are more e2e tests being run. What's holding us back from being able to randomly assign these tests to different AWS regions? |
Dev Productivity bumping resource limits (instance counts, etc.) for additional regions. Hopefully happens in the next few weeks. |
@davidvossel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@davidvossel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@davidvossel: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The ocs-operator uses failure domains to help spread out placement of ceph mon and osd daemons across multiple availability zones.
In order to test in an environment as close to production as possible, ideally we'd like to our e2e functional test environment to supply us with 3 availability zones. At the moment the standard aws e2e cluster is only using
us-east-1a
andus-east-1b
. Our request is to expand that list to includeus-east-1c
as well.If we can't make this change directly to the standard aws e2e cluster setup template, is this something that we can parameterize?