Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: drop max azure CI clusters to 5 #5074

Merged

Conversation

yuqi-zhang
Copy link
Contributor

After we updated azure disks: openshift/installer#2367
We require 34 cores per cluster. This means (at a current limit of
200vCPUs) we can only safely support 5 running jobs at a time.

Signed-off-by: Yu Qi Zhang jerzhang@redhat.com

After we updated azure disks: openshift/installer#2367
We require 34 cores per cluster. This means (at a current limit of
200vCPUs) we can only safely support 5 running jobs at a time.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2019
@droslean
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit a3b07bb into openshift:master Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: Updated the resources configmap in namespace ci using the following files:

  • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml

In response to this:

After we updated azure disks: openshift/installer#2367
We require 34 cores per cluster. This means (at a current limit of
200vCPUs) we can only safely support 5 running jobs at a time.

Signed-off-by: Yu Qi Zhang jerzhang@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Contributor

This is not a fix. We have WAY more than that number of jobs.

wking added a commit to wking/openshift-release that referenced this pull request Sep 18, 2019
… Random Azure regions

Shard over four regions to increase our capacity, because Azure allows
auto-bumps for vCPU limits up to 200 in each region, but it's a longer
process to get the limits raised beyond that in a single region.  This
sets us up for more lease-restriction relaxing after 78ade84 (Prow:
drop max azure CI clusters to 5, 2019-09-18, openshift#5074) and 594930f
(Prow: increase max Azure CI clusters to 20, 2019-09-18, openshift#5084).  We
may want per-region quotas, but for the moment I'm just hoping that
our random choices are even enough that an Azure-wide quota is
sufficient.  And conveniently, $RANDOM runs from 0 through 32767 [1],
so our modulo 4 value is evenly weighted :).

The change to Bash is because Bash supports $RANDOM [1], but POSIX
does not [2].  We already use RANDOM in
openshift-installer-master-presubmits.yaml since ca464ed
(openshift/installer: add IaaS-agnostic E2E test, 2019-06-20, openshift#4148).

Ideally we'd be loading the set of region choices (and possibly
weights) from some shared location somewhat like ca464ed has
things.  And we'd be reporting the chosen region in a structured way
for convenient monitoring.  But the plan is to break up these
templates into more composable chunks soon anyway, so I'm ok if we
aren't all that DRY in the short term.

[1]: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#index-RANDOM
[2]: https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xcu_chap02.html#tag_23_02_05_03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants