ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e: Push AWS-specific default BASE_DOMAIN down into the template #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/XS
|
/test pj-rehearse |
wking
force-pushed
the
platform-specific-base-domain-defaults
branch
7 times, most recently
from
958b34e
to
362f252
Compare
openshift-ci-robot
added
size/S
…i-e2e: Push AWS-specific default base domain down into the template
We want to set per-platform defaults to make life easier for folks
consuming these templates. := is in POSIX [1]. The new lowercase
form is because ${BASE_DOMAIN} expansion is happening at the
Go-template level, so attempting to do:
echo "Base domain: ${BASE_DOMAIN:=origin-ci-int-aws.dev.rhcloud.com}"
echo "FIXME: testing BASE_DOMAIN: ${BASE_DOMAIN}"
results in [2]:
Base domain: origin-ci-int-aws.dev.rhcloud.com
FIXME: testing BASE_DOMAIN:
It is a bit strange to have vSphere using a domain that includes
"aws", but it seems to work [3]:
$ curl -s https://storage.googleapis.com/origin-ci-test/logs/canary-openshift-ocp-installer-e2e-vsphere-upi-4.2/180/artifacts/e2e-vsphere-upi/installer/.openshift_install.log | grep aws | head -n1
time="2019-09-23T17:21:17Z" level=info msg="Waiting up to 30m0s for the Kubernetes API at https://api.ci-op-4jhq8mjx-f1a95.origin-ci-int-aws.dev.rhcloud.com:6443..."
Clayton says this is because we're currently running our vSphere CI on
AWS, which makes sense.
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02
[2]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/5151/rehearse-5151-pull-ci-openshift-installer-master-e2e-aws-upi/4
[3]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/canary-openshift-ocp-installer-e2e-vsphere-upi-4.2/180
wking
force-pushed
the
platform-specific-base-domain-defaults
branch
from
362f252
to
43e08e7
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Works with |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 15, 2020
Like 7aa198b (ci-operator/step-registry/ipi/conf/azure: Get region from Boskos lease, 2020-10-14, openshift#12584), but for AWS. I'm keeping a switch for AWS to give folks a pattern for selecting zones, if AWS breaks a zone in a particular region. We should probably distribute that (and the shared subnets, for shared-subnet tests?) via leases as well, but baby steps. I'm leaving ci-operator/templates alone; hopefully those will be gone soon. I've already updated ci-tools with openshift/ci-tools@00ebab17e1 (pkg/steps/clusterinstall/template: Get region from Boskos lease, 2020-12-11, openshift/ci-tools#1527). I'm also normalizing to uppercase shell variables, now that we are no longer constrained by Go template expansion. Hmm, at least that's why I thought the variables used to be lowercase, see 43e08e7 (ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e: Push AWS-specific default base domain down into the template, 2019-09-23, openshift#5151). But looking at the templates when de3de20 (step-registry: add configure and install IPI steps, 2020-01-14, openshift#6708), I'm now not sure why these step commands were using lowercase variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to set per-platform defaults to make life easier for folks consuming these templates.