Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP CONTROL_ARCH or COMPUTE_ARCH should respect OCP_ARCH #54555

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jianlinliu
Copy link
Contributor

@jianlinliu jianlinliu commented Jul 19, 2024

Follow up #54324

Per the log, when either CONTROL_ARCH or COMPUTE_ARCH is not set, but OCP_ARCH set, master_type is empty.

CONTROL_ARCH or COMPUTE_ARCH should respect OCP_ARCH.

@openshift-ci openshift-ci bot requested review from neisw and xueqzhan July 19, 2024 01:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-sdn-migration-ovn-arm-f28

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu jianlinliu changed the title debug CONTROL_ARCH or COMPUTE_ARCH should respect OCP_ARCH Jul 19, 2024
@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-sdn-migration-ovn-arm-f28

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-gcp-ovn-heterogeneous

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2024
@jianlinliu jianlinliu changed the title CONTROL_ARCH or COMPUTE_ARCH should respect OCP_ARCH GCP CONTROL_ARCH or COMPUTE_ARCH should respect OCP_ARCH Jul 19, 2024
@jianlinliu
Copy link
Contributor Author

cc @tvardema to review.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a minor comment

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-router-master-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.18-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.17-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.16-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.15-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.14-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.13-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.12-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.11-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.10-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.9-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.8-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.7-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.6-e2e-agnostic openshift/router presubmit Registry content changed
pull-ci-openshift-router-release-4.6-e2e-upgrade openshift/router presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-master-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.18-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.17-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.16-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.15-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.14-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.13-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.12-e2e-gcp-ovn openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.11-e2e-gcp openshift/openshift-controller-manager presubmit Registry content changed
pull-ci-openshift-openshift-controller-manager-release-4.10-e2e-gcp openshift/openshift-controller-manager presubmit Registry content changed

A total of 3243 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-sdn-migration-ovn-arm-f28 periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-gcp-ovn-heterogeneous

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 065abfa into openshift:master Jul 19, 2024
12 of 14 checks passed
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@jianlinliu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-sdn-migration-ovn-arm-f28 213d6e3 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-sdn-migration-ovn-arm-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants