Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreos: Fix buildroot trigger #5488

Merged
merged 1 commit into from
Oct 18, 2019
Merged

coreos: Fix buildroot trigger #5488

merged 1 commit into from
Oct 18, 2019

Conversation

cgwalters
Copy link
Member

There's no master. Should ensure the buildroot actually
gets rebuilt.

@cgwalters cgwalters mentioned this pull request Oct 17, 2019
Merged
@jlebon
Copy link
Member

jlebon commented Oct 17, 2019

Ahh nice!
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2019
@ashcrow
Copy link
Member

ashcrow commented Oct 17, 2019

For some added background, :master does exist in some OCP environments that build off master. However, for this use it does not and :latest is most likely the right tag.

@cgwalters
Copy link
Member Author

/retest

@cgwalters
coreos: Fix buildroot trigger
3f48b6c 
There's no `master`.  Should ensure the buildroot actually
gets rebuilt.
@cgwalters cgwalters force-pushed the coreos-buidlroot-trigger branch from 22ce74d to 3f48b6c Compare October 18, 2019 16:09
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 18, 2019
@jlebon
Copy link
Member

jlebon commented Oct 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit eb790e0 into openshift:master Oct 18, 2019
@jlebon
Copy link
Member

jlebon commented Nov 21, 2019

Hmm, it looks like this change wasn't applied automatically to the running cluster. I fixed it manually, though was that expected?

@jlebon jlebon mentioned this pull request Nov 21, 2019
Merged
@jlebon jlebon mentioned this pull request Feb 4, 2020
Merged
@jlebon jlebon mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@ashcrow ashcrow ashcrow approved these changes

Assignees

@ashcrow ashcrow

@dustymabe dustymabe

@jlebon jlebon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cgwalters @jlebon @ashcrow @openshift-ci-robot @dustymabe @openshift-merge-robot