Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding ocp 4.19 to the test matrix of nvidia gpu-operator #60118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomerNewman
Copy link
Contributor

When we will have a rc ready, we should add to the test matrix ocp version 4.19 as well to run on a weekly basis on Thursday, but I can change it to another date if you would prefer :)


/cc @empovit

@openshift-ci openshift-ci bot requested a review from empovit December 23, 2024 11:33
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 23, 2024
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TomerNewman
Once this PR has been reviewed and has the lgtm label, please assign ybettan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 23, 2024
When we will have a rc ready, we should add to the test matrix ocp version 4.19 as well to run on a weekly basis.
@TomerNewman TomerNewman force-pushed the feature/running-nvidia-gpu-on-4.19 branch from 309bb13 to 9631d4b Compare December 23, 2024 12:06
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@TomerNewman: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-nvidia-ci-main-4.19-images rh-ecosystem-edge/nvidia-ci presubmit Presubmit changed
periodic-ci-rh-ecosystem-edge-nvidia-ci-main-4.19-nvidia-gpu-operator-e2e-24-6-x N/A periodic Periodic changed
periodic-ci-rh-ecosystem-edge-nvidia-ci-main-4.19-nvidia-gpu-operator-e2e-24-9-x N/A periodic Periodic changed
periodic-ci-rh-ecosystem-edge-nvidia-ci-main-4.19-nvidia-gpu-operator-e2e-master N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

@TomerNewman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants