Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sno path #60119

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Fix sno path #60119

merged 3 commits into from
Dec 24, 2024

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Dec 23, 2024

Add a small hack to fetch SNO's kubeconfig from right path, as jetlag stores it in a directory with the SNO cluster name (which matches the hostname of the node)

/cc @josecastillolema

@rsevilla87
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rsevilla87
Copy link
Member Author

/cc @josecastillolema

@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema
Copy link
Contributor

/pj-rehearse network-access-allowed

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87
Copy link
Member Author

/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rsevilla87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-deploy-sno openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-node-density-heavy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-data-path-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-web-burner-node-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.17-latest-x86-web-burner-cluster-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-deploy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-deploy-sno openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-node-density-heavy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-data-path-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-web-burner-node-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.15-latest-x86-web-burner-cluster-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-deploy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-deploy-sno openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-node-density-heavy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-data-path-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-data-path-cnv-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-web-burner-node-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-dev-latest-x86-web-burner-cluster-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-deploy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-deploy-sno openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-node-density-heavy-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-data-path-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-web-burner-node-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-metal-4.14-latest-x86-web-burner-cluster-density-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed

A total of 39 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rsevilla87
Copy link
Member Author

/pj-rehearse-ack

@openshift-ci-robot
Copy link
Contributor

@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
Copy link
Contributor

openshift-ci bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josecastillolema, rsevilla87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josecastillolema
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2024
@josecastillolema
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 24, 2024
@openshift-ci-robot
Copy link
Contributor

@rsevilla87: job(s): /pj-rehearse-ack either don't exist or were not found to be affected, and cannot be rehearsed

Copy link
Contributor

openshift-ci bot commented Dec 24, 2024

@rsevilla87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2530ca8 into openshift:master Dec 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants