Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: Add large and xlarge variants #6081

Merged
merged 1 commit into from
Nov 25, 2019
Merged

templates: Add large and xlarge variants #6081

merged 1 commit into from
Nov 25, 2019

Conversation

smarterclayton
Copy link
Contributor

These variants increase the size of master nodes so we can launch
larger clusters.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@smarterclayton
templates: Add large and xlarge variants
cdf9716 
These variants increase the size of master nodes so we can launch
larger clusters.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2019
@wking
Copy link
Member

wking commented Nov 25, 2019

Did you want to bump the UPI template too? Metal template? Or are we going to take this in a few baby steps?

@smarterclayton
Copy link
Contributor Author

Right now I just want to test with AWS (the primary reason to do large is so we can launch a cluster from the bot that is capable of scaling to 1k nodes)

@openshift-merge-robot openshift-merge-robot merged commit ffe3ba6 into openshift:master Nov 25, 2019
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the following 5 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml

In response to this:

These variants increase the size of master nodes so we can launch
larger clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

Right now I just want to test with AWS (the primary reason to do large is so we can launch a cluster from the bot that is capable of scaling to 1k nodes)

@smarterclayton do we have enough IPs in the default case to support 1000 nodes... ?

the default are https://github.com/openshift/installer/blob/a9c3395b1b51d418d5e9ff1490148647f36c2cd3/pkg/types/defaults/installconfig.go#L19-L20
that allow 512 pods and 512 nodes??

@openshift-ci-robot
Copy link
Contributor

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/cloud-credential-operator/master/e2e-azure cdf9716 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-actuator-pkg/master/e2e-azure-operator cdf9716 link /test pj-rehearse
ci/prow/pj-rehearse cdf9716 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 26, 2019 via email

wking added a commit to wking/ci-tools that referenced this pull request Dec 20, 2019
@wking
pkg/steps/clusterinstall/template: Sync with openshift/release
92631f1 
Bringing over a number of changes which have landed in
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
as of openshift/release@016eb4ed27 (Merge pull request
openshift/release#6505 from hongkailiu/clusterReaders, 2019-12-19).
One series was improved kill logic:

* openshift/release@9cd158adf3 (template: Use a more correct kill
  command, 2019-12-03, openshift/release#6223).
* openshift/release@d0744e520d (exit with 0 even if kill failed,
  2019-12-09, openshift/release#6295)

Another series was around AWS instance console logs:

* openshift/release@e102a16d89
  (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e:
  Gather node console logs on AWS, 2019-12-02,
  openshift/release#6189).
* openshift/release@26fde70045
  (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e:
  Set AWS_DEFAULT_REGION, 2019-12-04, openshift/release#6249).

And there was also:

* openshift/release@cdf97164aa (templates: Add large and xlarge
  variants, 2019-11-25, openshift/release#6081).
* openshift/release@8cbef5e4a7
  (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e:
  Error-catching for Google OAuth pokes, 2019-12-02,
  openshift/release#6190).
* openshift/release@ad29eda8dd (template: Gather the prometheus target
  metadata during teardown, 2019-12-12, openshift/release#6379).
@wking wking mentioned this pull request Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smarterclayton @openshift-ci-robot @wking @abhinavdahiya @openshift-merge-robot