Skip to content

Update ocp4e2e golang version #69499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Update ocp4e2e golang version #69499

merged 1 commit into from
Sep 24, 2025

Conversation

@rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Sep 20, 2025

The recent refactor we've been doing is using newer golang features.
Update to a version of golang that's recent.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 20, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2025

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd rhmdnd force-pushed the update-ocp4e2e-golang-version branch from 097a303 to ebacc27 Compare September 22, 2025 15:42
@rhmdnd
Update ocp4e2e golang version
9d76034 
The recent refactor we've been doing is using newer golang features.
Update to a version of golang that's recent.
@rhmdnd rhmdnd force-pushed the update-ocp4e2e-golang-version branch from ebacc27 to 9d76034 Compare September 22, 2025 15:51
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 22, 2025

Moved from golang-1.24 to golang-1.23 since the 1.24 tag doesn't exist in the CI registry, yet.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2025

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis ComplianceAsCode/ocp4e2e presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-stig ComplianceAsCode/ocp4e2e presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-openshift-node-compliance ComplianceAsCode/ocp4e2e presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-openshift-platform-compliance ComplianceAsCode/ocp4e2e presubmit Ci-operator config changed
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-rhcos4-moderate ComplianceAsCode/ocp4e2e presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 22, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2025

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 22, 2025

Getting some good initial results with the golang version bump.

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2025

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/ComplianceAsCode/ocp4e2e/main/e2e-aws-ocp4-cis 9d76034 link unknown /pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis
ci/rehearse/ComplianceAsCode/ocp4e2e/main/e2e-aws-openshift-node-compliance 9d76034 link unknown /pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Sep 24, 2025
Merged
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

@JAORMX: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yuumasato
yuumasato approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhmdnd It looks like the master node pool is stuck and not updating, this is unrelated to this PR though. Other tests ran fine.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@yuumasato
Copy link
Contributor

yuumasato commented Sep 24, 2025

/lgtm
/pj-rehearse ack

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 24, 2025

@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 70c1348 into openshift:master Sep 24, 2025
16 of 18 checks passed
@rhmdnd rhmdnd mentioned this pull request Sep 24, 2025
Merged
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
@rhmdnd @xiaojiey
Update ocp4e2e golang version (openshift#69499)
7fba8a4 
The recent refactor we've been doing is using newer golang features.
Update to a version of golang that's recent.
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
@rhmdnd @abhay-nutanix
Update ocp4e2e golang version (openshift#69499)
d641ae7 
The recent refactor we've been doing is using newer golang features.
Update to a version of golang that's recent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vincent056 Vincent056 Awaiting requested review from Vincent056

2 more reviewers

@JAORMX JAORMX JAORMX approved these changes

@yuumasato yuumasato yuumasato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuumasato yuumasato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhmdnd @openshift-ci-robot @yuumasato @JAORMX