Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/step-registry/ipi/conf: Drop to 10m #7650

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

wking
Copy link
Member

@wking wking commented Mar 13, 2020

It's been 1000m since it landed in de3de20 (#6708), but it's a pretty simple container (just write a config file), so @stevekuznetsov suggestes 10m as more appropriate.

It's been 1000m since it landed in de3de20 (step-registry: add
configure and install IPI steps, 2020-01-14, openshift#6708), but it's a pretty
simple container (just write a config file), so Steve suggestes 10m as
more appropriate [1].

[1]: openshift#7625 (comment)
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1235fdc into openshift:master Mar 16, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the step-registry configmap in namespace ci at cluster default using the following files:

  • key ipi-conf-ref.yaml using file ci-operator/step-registry/ipi/conf/ipi-conf-ref.yaml

In response to this:

It's been 1000m since it landed in de3de20 (#6708), but it's a pretty simple container (just write a config file), so @stevekuznetsov suggestes 10m as more appropriate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-steps d65aeab link /test pj-rehearse
ci/prow/pj-rehearse d65aeab link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the 10m-ipi-conf-step branch March 16, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants