ci-operator/step-registry/ipi/deprovision/vsphere: Decompose into sub-steps #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
wking
force-pushed
the
vsphere-deprovision-decomposition
branch
from
76bf2a5
to
4b787fb
Compare
wking
force-pushed
the
vsphere-deprovision-decomposition
branch
from
4b787fb
to
6aa9753
Compare
ci-operator/step-registry/ipi/deprovision/vsphere/dns/ipi-deprovision-vsphere-dns-ref.yaml
Outdated
Show resolved
Hide resolved
|
LGTM /assign @patrickdillon |
wking
force-pushed
the
vsphere-deprovision-decomposition
branch
from
6aa9753
to
71b2160
Compare
…-steps So we can recycle the vanilla IPI deprovision step without needing to make changes to it (other than using the UPI image to get the vSphere CA certs). This also makes the link between the resource-creating and resource-destroying steps more transparent. Also store the hosted zone ID in a secret so we don't have to look it up again, which lets us simplify the secret loading a bit in the DNS deprovisioning. Remove the ipi-deprovision-vsphere chain, since there's no reason folks would use it instead of the ipi-vsphere-post chain.
wking
force-pushed
the
vsphere-deprovision-decomposition
branch
from
71b2160
to
a466b83
Compare
|
/lgtm |
openshift-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
vsphere rehearsal failed waiting for the Kube API:
So I think we're in a pretty good space here. |
/hold cancel No need, since this pivot. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #7931; review that first.
So we can recycle the vanilla IPI deprovision step without needing to make changes to it (other than using the UPI image to get the vSphere CA certs). This also makes the link between the resource-creating and resource-destroying steps more transparent.
Also store the hosted zone ID in a secret so we don't have to look it up again, which lets us simplify the secret loading a bit in the DNS deprovisioning.
Remove the ipi-deprovision-vsphere chain, since there's no reason folks would use it instead of the ipi-vsphere-post chain.