create a hybrid cluster and run the e2e tests on it #8075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobTanenbaum
force-pushed
the
e2e-aws-ovn-hybrid
branch
3 times, most recently
from
eaba01b
to
d17b7fb
Compare
|
/retest |
JacobTanenbaum
force-pushed
the
e2e-aws-ovn-hybrid
branch
3 times, most recently
from
ed8d728
to
a36526a
Compare
|
@stevekuznetsov PTAL |
|
|
||
| TF_LOG=debug openshift-install --dir="${dir}" create manifests | ||
|
|
||
| cat >> "${dir}/manifests/cluster-network-03-config.yml" << EOF |
There was a problem hiding this comment.
I would much rather see you break apart the current install step into a manifest-create and a run-install or something. Whenver we find ourselves copy-pasting in this system we need to be refactoring to make this reusable
There was a problem hiding this comment.
updated with the code split into steps
JacobTanenbaum
force-pushed
the
e2e-aws-ovn-hybrid
branch
from
407363e
to
ba96aa9
Compare
| @@ -0,0 +1,31 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I meant -- everyone running the installer should ideally be using the same steps to do so, or we have drift. So this should underpin the IPI install flow, too.
JacobTanenbaum
force-pushed
the
e2e-aws-ovn-hybrid
branch
2 times, most recently
from
222094e
to
355b05c
Compare
|
/retest |
JacobTanenbaum
force-pushed
the
e2e-aws-ovn-hybrid
branch
from
355b05c
to
6d03e1a
Compare
|
/retest |
|
@JacobTanenbaum: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
stevekuznetsov
approved these changes
Apr 6, 2020
| @@ -7,4 +7,4 @@ ref: | |||
| cpu: 1000m | |||
| memory: 2Gi | |||
| documentation: |- | |||
| The IPI install step runs the OpenShift Installer in order to bring up an OpenShift cluster, using the provided cluster profile to choose a target IaaS platform. | |||
| The IPI install step runs the OpenShift Installer in order to bring up an OpenShift cluster, using the provided cluster profile to choose a target IaaS platform. Anything that needs to be configured using manifests should generate them before this step and put them in the SHARED_DIR with the filename manifest_(manifest_name).yml so that this step can pull in the manifest in. | |||
There was a problem hiding this comment.
@AlexNPavel can we embed HTML here or something? I would love to see a fully-fledged example.
There was a problem hiding this comment.
we could allow markdown and use https://godoc.org/github.com/gomarkdown/markdown/html to convert to html for steps.svc.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JacobTanenbaum, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@JacobTanenbaum: Updated the following 9 configmaps:
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 13, 2020
…ests' No Terraform involved in creating manifests. Cleans up after d11bca7 (create a hybrid cluster and run the e2e tests on it, 2020-04-01, openshift#8075). Also removes trailing whitespace from the YAML documentation. Also backgrounds the 'create manifests' call and immediately waits for it, so we can gracefully handle TERM as described in 4472ace (ci-operator/templates/openshift/installer: Restore backgrounded 'create cluster', 2019-01-23, openshift#2680).
aravindhp
added a commit
to aravindhp/release
that referenced
this pull request
Apr 14, 2020
Use the hybrid OVN step registry introduced in openshift#8075 for the operator's e2e tests. Ran `make jobs` after adding the step registry config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.