Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using step registry in WMCO #8323

Merged

Conversation

aravindhp
Copy link
Contributor

@aravindhp aravindhp commented Apr 14, 2020

  • Add AWS Hybrid OVN workflow
  • Add WMCO e2e test ref that uses the AWS Hybrid OVN workflow
  • Use the WMCO e2e test ref in the WCMO configs

Ran make validate-step-registry and make jobs.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@aravindhp
Copy link
Contributor Author

/cc @openshift/openshift-team-windows-containers @dcbw @JacobTanenbaum

aravindhp added a commit to aravindhp/release that referenced this pull request Apr 15, 2020
This reverts commit 62ccb9e, reversing changes made to 16bc9d3 by
running `git revert -m 1 62ccb9e`.

Reverting this to move back to using templates until we figure out openshift#8323.
@aravindhp aravindhp force-pushed the hybrid-ovn-step-registry branch 2 times, most recently from 2909ece to 431d592 Compare April 15, 2020 23:24
aravindhp added a commit to aravindhp/windows-machine-config-operator that referenced this pull request Apr 16, 2020
Problem: hack/run-ci-e2e-test.sh fails in the following manner as
observed when working on openshift/release#8323:
```
 failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied
Error: failed to build test binary: ...
```

Solution: Preemptively create the go cache directory in the image being
built by CI.
@aravindhp aravindhp changed the title WIP: Add AWS Hybrid OVN workflow and use it in WMCO WIP: Move to using step registry in WMCO Apr 17, 2020
@aravindhp
Copy link
Contributor Author

/retest

1 similar comment
@aravindhp
Copy link
Contributor Author

/retest

@aravindhp
Copy link
Contributor Author

/retest

1 similar comment
@aravindhp
Copy link
Contributor Author

/retest

@aravindhp
Copy link
Contributor Author

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@aravindhp: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/windows-machine-config-operator/release-4.5/e2e-operator f33495be69e9c579047f499fe8f59701ae02c6c0 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.6/e2e-operator f33495be69e9c579047f499fe8f59701ae02c6c0 link /test pj-rehearse
ci/prow/pj-rehearse f33495be69e9c579047f499fe8f59701ae02c6c0 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aravindhp aravindhp changed the title WIP: Move to using step registry in WMCO Move to using step registry in WMCO Apr 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2020
- Add AWS Hybrid OVN workflow
- Add WMCO e2e test ref that uses the AWS Hybrid OVN workflow
- Use the WMCO e2e test ref in the WCMO configs

Ran `make validate-step-registry` and `make jobs`.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 812635c into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

@aravindhp: Updated the following 17 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.5-presubmits.yaml
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/aws/ovn/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/aws/ovn/hybrid/OWNERS
    • key ipi-aws-ovn-hybrid-workflow.yaml using file ci-operator/step-registry/ipi/aws/ovn/hybrid/ipi-aws-ovn-hybrid-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/windows/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/operator/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/operator/test/OWNERS
    • key windows-e2e-operator-test-commands.sh using file ci-operator/step-registry/windows/e2e/operator/test/windows-e2e-operator-test-commands.sh
    • key windows-e2e-operator-test-ref.yaml using file ci-operator/step-registry/windows/e2e/operator/test/windows-e2e-operator-test-ref.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/aws/ovn/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/aws/ovn/hybrid/OWNERS
    • key ipi-aws-ovn-hybrid-workflow.yaml using file ci-operator/step-registry/ipi/aws/ovn/hybrid/ipi-aws-ovn-hybrid-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/windows/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/operator/OWNERS
    • key OWNERS using file ci-operator/step-registry/windows/e2e/operator/test/OWNERS
    • key windows-e2e-operator-test-commands.sh using file ci-operator/step-registry/windows/e2e/operator/test/windows-e2e-operator-test-commands.sh
    • key windows-e2e-operator-test-ref.yaml using file ci-operator/step-registry/windows/e2e/operator/test/windows-e2e-operator-test-ref.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-windows-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.5.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.6-presubmits.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.6.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.6-presubmits.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.6.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-windows-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.6.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

In response to this:

  • Add AWS Hybrid OVN workflow
  • Add WMCO e2e test ref that uses the AWS Hybrid OVN workflow
  • Use the WMCO e2e test ref in the WCMO configs

Ran make validate-step-registry and make jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aravindhp added a commit to aravindhp/windows-machine-config-operator that referenced this pull request Apr 28, 2020
Now that we are using the
[step registry workflow](openshift/release#8323) for bringing up a
hybrid OVN cluster in CI, we can stop patching the network.operator CR
to enable hybrid networking.
@aravindhp aravindhp deleted the hybrid-ovn-step-registry branch April 28, 2020 19:05
ravisantoshgudimetla pushed a commit to ravisantoshgudimetla/windows-machine-config-operator-1 that referenced this pull request May 12, 2020
Problem: hack/run-ci-e2e-test.sh fails in the following manner as
observed when working on openshift/release#8323:
```
 failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied
Error: failed to build test binary: ...
```

Solution: Preemptively create the go cache directory in the image being
built by CI.
ravisantoshgudimetla pushed a commit to ravisantoshgudimetla/windows-machine-config-operator-1 that referenced this pull request May 12, 2020
Now that we are using the
[step registry workflow](openshift/release#8323) for bringing up a
hybrid OVN cluster in CI, we can stop patching the network.operator CR
to enable hybrid networking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants