vSphere UPI: Migrate to steps #9552
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
2 times, most recently
from
deef822
to
46bdb3d
Compare
|
/test pj-rehearse |
|
/retest |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
|
/retest |
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
from
624f7c1
to
fe8578b
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test all |
2 similar comments
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
3 similar comments
|
/test all |
|
/test all |
|
/test all |
|
/test pj-rehearse |
|
/test all |
2 similar comments
|
/test all |
|
/test all |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
from
3e3fb92
to
c46e740
Compare
|
/test all |
ci-operator/step-registry/upi/deprovision/vsphere/upi-deprovision-vsphere-commands.sh
Outdated
Show resolved
Hide resolved
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
3 times, most recently
from
fa23f5d
to
fb2dadd
Compare
|
|
vsphere isn't busy... |
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
2 times, most recently
from
4ff4ced
to
7338efc
Compare
|
@wking @abhinavdahiya this is ready to go can you PTAL. |
|
/assign @abhinavdahiya |
ci-operator/step-registry/upi/conf/vsphere/ova/upi-conf-vsphere-ova-commands.sh
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/upi/conf/vsphere/upi-conf-vsphere-commands.sh
Outdated
Show resolved
Hide resolved
| # To ease debugging of ip address use | ||
| cluster_domain=$(<"${SHARED_DIR}"/clusterdomain.txt) | ||
| host -t A "api.${cluster_domain}" |
There was a problem hiding this comment.
not sure what this is helping with debugging?
There was a problem hiding this comment.
I suppose there could be a better way to disable what IP addresses were used but its nice to know what is resolvable.
The major reason is if/when there is issues when two clusters overlap ip addresses.
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
| "${dir}/metadata.json" \ | ||
| ${dir}/*.ign | ||
|
|
||
| # Removed tar of openshift state. Not enough room in SHARED_DIR with terraform state |
There was a problem hiding this comment.
did we end up creating something for test platform team to help fix this. the 1mb restriction is not helping UPI workflows.
There was a problem hiding this comment.
Its a kubernetes limitation for a secret I am not sure how we would be working around that. I might be missing something but for vSphere UPI not sure why we need openshift state.
There was a problem hiding this comment.
Tucking the metadata into the cluster itself is one option, but maybe install failed. In that case, I think the option are:
- Tucking the data into a separate storage engine like S3 (I think Ahbinav also floated matchbox?).
- Reducing the amount of data that you need to share. Can we teardown with some subset of the Terraform state?
And it's not clear to me why we'd want to share the installer's state file between steps, even if we didn't have to make room for a large Terraform state dump.
Also in this space, CI jobs can fail if a CI node goes down, which happens sometimes. We'll want a stateless way to reap the resources that sort of hard-termination leaks, and it's possible we can recycle some of that approach for the official teardown step to reduce the amount of state it needs passed in.
ci-operator/step-registry/upi/install/vsphere/upi-install-vsphere-commands.sh
Show resolved
Hide resolved
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
from
7338efc
to
aa470f8
Compare
|
/test pj-rehearse |
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
2 times, most recently
from
08b00ed
to
04f1da1
Compare
Moved what was defined in the templates for vSphere and migrated to steps.
jcpowermac
force-pushed
the
vsphere_upi_steps
branch
from
04f1da1
to
8b3db8f
Compare
|
@abhinavdahiya can you take another look when you have a chance? |
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jcpowermac, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jcpowermac: Updated the following 8 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Moved what was defined in the templates for vSphere
and migrated to steps.