Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-9778 | test: Automate OCP-57094 Describe/List rosa upgrade via rosacli #2281

Merged
merged 1 commit into from
Aug 2, 2024
Merged

OCM-9778 | test: Automate OCP-57094 Describe/List rosa upgrade via rosacli #2281

merged 1 commit into from
Aug 2, 2024

Conversation

jameszwang
Copy link
Contributor

No description provided.

@jameszwang jameszwang force-pushed the ocm-9778 branch 2 times, most recently from b0ff521 to edb88b2 Compare July 24, 2024 09:28
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.79%. Comparing base (22f38bd) to head (edb88b2).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2281   +/-   ##
=======================================
  Coverage   26.79%   26.79%           
=======================================
  Files         154      154           
  Lines       21857    21857           
=======================================
  Hits         5856     5856           
  Misses      15551    15551           
  Partials      450      450

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
radtriste
radtriste reviewed Jul 26, 2024
View reviewed changes
tests/e2e/test_rosacli_cluster.go Outdated Show resolved Hide resolved
tests/utils/exec/rosacli/cluster_service.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
@jameszwang
Copy link
Contributor Author

/retest

radtriste
radtriste reviewed Jul 29, 2024
View reviewed changes
tests/utils/exec/rosacli/upgrade_service.go Outdated Show resolved Hide resolved
tests/e2e/test_rosacli_upgrade.go Outdated Show resolved Hide resolved
tests/e2e/test_rosacli_upgrade.go Outdated Show resolved Hide resolved
tests/e2e/test_rosacli_upgrade.go Outdated Show resolved Hide resolved
tests/utils/common/constants/general.go Outdated Show resolved Hide resolved
tests/e2e/test_rosacli_upgrade.go Outdated Show resolved Hide resolved
@jameszwang jameszwang force-pushed the ocm-9778 branch 2 times, most recently from 01e641e to e30f428 Compare July 30, 2024 04:13
@jameszwang jameszwang force-pushed the ocm-9778 branch 6 times, most recently from 3ed98ff to 1b9b0f4 Compare August 2, 2024 07:21
@jameszwang
Copy link
Contributor Author

/retest

@jameszwang
Copy link
Contributor Author

/retest-required

@jameszwang
Copy link
Contributor Author

/test e2e-presubmits-pr-rosa-hcp-advanced

@jameszwang
Copy link
Contributor Author

/test e2e-presubmits-pr-rosa-hcp-advanced

radtriste
radtriste approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jameszwang, radtriste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73dabb4 and 2 for PR HEAD cbc8a8d in total

@jameszwang
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit ea34107 into openshift:master Aug 2, 2024
9 of 11 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

@jameszwang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-presubmits-pr-rosa-hcp-advanced cbc8a8d link false /test e2e-presubmits-pr-rosa-hcp-advanced

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radtriste radtriste radtriste approved these changes

@mgahagan73 mgahagan73 Awaiting requested review from mgahagan73

@OAharoni-RedHat OAharoni-RedHat Awaiting requested review from OAharoni-RedHat

Assignees

@radtriste radtriste

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameszwang @openshift-ci-robot @radtriste @openshift-merge-robot