hack: add helper interactive script for setting peer-pods-cm #448
Conversation
|
@Saripalli-lavanya pls see if this workflow could help for the libvirt case as well (#436), thanks |
| AZURE_INSTANCE_SIZE=${AZURE_INSTANCE_SIZE:-Standard_B2als_v2} | ||
| AZURE_INSTANCE_SIZES=${AZURE_INSTANCE_SIZES:-Standard_B2als_v2,Standard_D2as_v5,Standard_D4as_v5,Standard_D2ads_v5} | ||
| [[ "${DISABLECVM}" == true ]] && AZURE_INSTANCE_SIZE=${AZURE_INSTANCE_SIZE:-Standard_B2als_v2} || AZURE_INSTANCE_SIZE=${AZURE_INSTANCE_SIZE:-Standard_DC2as_v5} | ||
| [[ "${DISABLECVM}" == true ]] && AZURE_INSTANCE_SIZES=${AZURE_INSTANCE_SIZES:-Standard_B2als_v2,Standard_D2as_v5,Standard_D4as_v5,Standard_D2ads_v5} |
There was a problem hiding this comment.
We don't define AZURE_INSTANCE_SIZES for CoCo ?
There was a problem hiding this comment.
User may define it, i didn't have an idea of an alternative types to suggest, actually, there's a problem with CoCo which the instance types are not available across regions commonly as normal VMs, hence, it's better user to set it explicitly
There was a problem hiding this comment.
I think for start this should be ok..
Also @Saripalli-lavanya, can some of the libvirt cm config be added here to start with. It'll be easier and faster imho.
There was a problem hiding this comment.
Sure, @bpradipt. For libvirt, the common optional variables are "CLOUD_PROVIDER", "PROXY_TIMEOUT", and "DISABLECVM". Additionally, LIBVIRT_IMAGE_ID would suffice. The rest are being handled through peer pod secrets.
|
/retest |
There was a problem hiding this comment.
@snir911 do you mind adding a md file or some headers to explain why this is important and when we should use it?
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
| ${CLI} get cm peer-pods-cm -n openshift-sandboxed-containers-operator -o jsonpath='{.data}' | jq | ||
| if ${CLI} get ds/peerpodconfig-ctrl-caa-daemon -n openshift-sandboxed-containers-operator > /dev/null 2>&1; then | ||
| [[ -n $YES ]] || (read -r -p "Restart DeamonSet so that CM will be taken into account? [y/N] " && [[ "$REPLY" =~ ^[Yy]$ ]]) || exit 0 | ||
| ${CLI} set env ds/peerpodconfig-ctrl-caa-daemon -n openshift-sandboxed-containers-operator REBOOT="$(date)" |
There was a problem hiding this comment.
Hi @snir911 !
One suggestion of a future improvement: next, you can ask user if she/he want to wait for the daemonset restart.
run locally once OSC operator is installed and KUBECONFIG is set. currently supports AWS and Azure clusters
|
@snir911: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hi @snir911 ! Thanks that helper is really a helper :) |
run locally once OSC operator is installed and KUBECONFIG is set. currently supports AWS and Azure clusters
This script intends to be simple as possible ans still be able to set all defaults..